Do not use deprecated TokenCache.find() - #36714
Merged
Merged
Conversation
azure-identity already requires msal>=1.29.0, so this should be safe. Fixes Azure#36713
Aarni Koskela (akx)
requested review from
a team,
Paul Van Eck (pvaneck) and
Xiang Yan (xiangyan99)
as code owners
August 1, 2024 12:05
github-actions
Bot
added
Azure.Identity
Community Contribution
Contributor
|
Thank you for your contribution Aarni Koskela (@akx)! We will review the pull request and get back to you soon. |
Collaborator
|
API change check API changes are not detected in this pull request. |
Xiang Yan (xiangyan99)
approved these changes
Aug 1, 2024
Xiang Yan (xiangyan99)
left a comment
Xiang Yan (xiangyan99)
left a comment
Member
There was a problem hiding this comment.
Thanks for your contributions. This looks great!
Libba Lawrence (l0lawrence)
pushed a commit
to l0lawrence/azure-sdk-for-python
that referenced
this pull request
Feb 19, 2025
azure-identity already requires msal>=1.29.0, so this should be safe. Fixes Azure#36713
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #36713 by not using the deprecated
TokenCache.find()method.azure-identity already requires msal>=1.29.0, so this should be safe.
There are other uses of
_cache.find()around the monorepo, but no other package declares that it depends on msal 1.29.0+, so changing those may not be safe.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines